search

izivkov / CasioGShockSmartSync

Apache License 2.0
115 stars 12 forks source link

Add find phone action #40

Closed germede closed 1 year ago

germede commented 1 year ago

Solves #39

izivkov commented 1 year ago

@gmedina-de This was really fast and looks good, but can we add the ability to stop the sound once we have found the phone? Maybe by creating a dialog with "Cancel Alarm" option. At the moment I had to turn off the phone to stop it.

Thanks for your contribution.

germede commented 1 year ago

@izivkov Sure, please find a new commit with a simple dialog.

izivkov commented 1 year ago

@gmedina-de Thanks for you contribution. I like your minimalist approach - exactly the philosophy i'm trying to promote for this projects. I hope you contribute in the future. If you have some ideas for a feature, or like to hear what features I have in mind, please let me know.

izivkov commented 1 year ago

@gmedina-de Just one more comment on this issue. The current solution is fine for now, but ideally, this action would be activated by long-pressing the lower-right button, just like is works with the Casio app. This involves modifying the getPressedButton() in GShockAPI library to return this new value for this long press, and then the app can take the action of calling the FindPhone action, similarly to how we handle the runActionsForAutoTimeSetting(). I will try to implement this in the future when I have some time.