izivkov / CasioGShockSmartSync

Apache License 2.0
112 stars 12 forks source link

Further Chinese-Simplified translation #54

Closed WeiguangTWK closed 10 months ago

WeiguangTWK commented 10 months ago

Further Chinese-Simplified translation Change: The name of app is set to untranslatable in string.xml

izivkov commented 10 months ago

OK, no problem.

I also found a couple of other small inconsistencies:

Do you think you can pull the latest code, and update your Pull Request with these changes in the Chinese strings.xml?

Thanks, Ivo

On Wed, Nov 15, 2023 at 7:43 PM Weiguangtwk @.***> wrote:

@.**** commented on this pull request.

In app/src/main/res/values-zh-rCN/strings.xml https://github.com/izivkov/CasioGShockSmartSync/pull/54#discussion_r1395021631 :

@@ -103,12 +102,12 @@

:
 <!-- New -->
  • No Watch
  • Set Time
  • Set Reminders from Google Calender
  • Take a photo
  • Toggle Flashlight
  • Start Voice Assist
  • Emergency Actions:
  • Make a phone call
  • 未添加手表
  • 自动设置事件
  • 自动从Google Calender添加待办
  • 照相
  • 启动闪光灯

If repeatedly running this action would turn the flash on and off, The translation should not be“打开闪光灯” but “切换闪光灯状态” instead, That's my problem, sorry

— Reply to this email directly, view it on GitHub https://github.com/izivkov/CasioGShockSmartSync/pull/54#discussion_r1395021631, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7M37X6V6XUJRWHW5QTPY3YEVOTFAVCNFSM6AAAAAA7MVXTYOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMZTGI4DMNRWGA . You are receiving this because you modified the open/close state.Message ID: @.***>

WeiguangTWK commented 10 months ago

OK, no problem. I also found a couple of other small inconsistencies: - I think "自动从Google Calender添加待办" should be just "Google Calendar Events", because this is it just the title of the screen. What you see on the page is just Google Calendar events. Also note that I misspelled it, it should be "Calendar, not Calender. I will fix the English part. - Also, for "No Watch" you have, "未添加手表", which I think it means "Watch not added". But actually, we are not adding a new watch, because this is not saved anywhere. It just become the current watch, which can be replaced later with another watch. So the message should say "No current watch", or "No watch" for short. Do you think you can pull the latest code, and update your Pull Request with these changes in the Chinese strings.xml? Thanks, Ivo On Wed, Nov 15, 2023 at 7:43 PM Weiguangtwk @.> wrote: @*.*** commented on this pull request. ------------------------------ In app/src/main/res/values-zh-rCN/strings.xml <#54 (comment)> : > @@ -103,12 +102,12 @@ : - No Watch - Set Time - Set Reminders from Google Calender - Take a photo - Toggle Flashlight - Start Voice Assist - Emergency Actions: - Make a phone call + 未添加手表 + 自动设置事件 + 自动从Google Calender添加待办 + 照相 + 启动闪光灯 If repeatedly running this action would turn the flash on and off, The translation should not be“打开闪光灯” but “切换闪光灯状态” instead, That's my problem, sorry — Reply to this email directly, view it on GitHub <#54 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7M37X6V6XUJRWHW5QTPY3YEVOTFAVCNFSM6AAAAAA7MVXTYOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMZTGI4DMNRWGA . You are receiving this because you modified the open/close state.Message ID: @.>

OK👌, I will apply changes later.