search

izivkov / GShockTimeServer

A python script to update time for G-Shock Watches
MIT License
16 stars 4 forks source link

Gatttool script and GShock protocol description #5

Closed harlock974 closed 11 months ago

izivkov commented 11 months ago

Hey @harlock974 , looks like you have done a lot of good work on this PR. I think we can merge after making these small changes I commented on.

harlock974 commented 11 months ago

Where can I see your comment ? (sorry I'm not used to do large commits)

izivkov commented 11 months ago

https://github.com/izivkov/GShockTimeServer/pull/5

On Sat, Jul 29, 2023 at 11:40 AM Pierre Brial @.***> wrote:

Where can I see your comment ? (sorry I'm not used to do large commits)

— Reply to this email directly, view it on GitHub https://github.com/izivkov/GShockTimeServer/pull/5#issuecomment-1656760611, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7M37XM6OQPGE7OU77EEQDXSUVGXANCNFSM6AAAAAA24RAUMY . You are receiving this because you commented.Message ID: @.***>

izivkov commented 11 months ago

Go to the Pull Request, and select "Conversations"

On Sat, Jul 29, 2023 at 11:54 AM Ivo Zivkov @.***> wrote:

https://github.com/izivkov/GShockTimeServer/pull/5

On Sat, Jul 29, 2023 at 11:40 AM Pierre Brial @.***> wrote:

Where can I see your comment ? (sorry I'm not used to do large commits)

— Reply to this email directly, view it on GitHub https://github.com/izivkov/GShockTimeServer/pull/5#issuecomment-1656760611, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7M37XM6OQPGE7OU77EEQDXSUVGXANCNFSM6AAAAAA24RAUMY . You are receiving this because you commented.Message ID: @.***>

izivkov commented 11 months ago

I merged your pull request, but I think people will not be aware of your scripts. Can you also add a few lines in the main README file describing your script and its location.

harlock974 commented 11 months ago

Good idea I'll do that.