Result is different from Google and iOS Library - Githubissues

iziz / libPhoneNumber-iOS

iOS port from libphonenumber (Google's phone number handling library)

Apache License 2.0

2.36k stars 464 forks source link

Result is different from Google and iOS Library #324

Closed duy-dindinn closed 4 years ago

duy-dindinn commented 4 years ago

Hello,

I am using version 1.0.2 and one of my phone number does not return the same result as Google demo site. The phone number is +65 8921 xxxx.

From iOS library:

- (NBEPhoneNumberType)getNumberType:(NBPhoneNumber *)phoneNumber;

returns UNKNOWN

- (BOOL)isValidNumberForRegion:(NBPhoneNumber *)number regionCode:(NSString *)regionCode;

return false

From Google:

Result from isPossibleNumber(): true
Result from isValidNumber(): true
Result from isValidNumberForRegion(): true
Phone Number region: SG
Result from getNumberType(): MOBILE

What should I do to get the correct result? Thanks in advance!

Regards, Duy

duy-dindinn commented 4 years ago

Fixed by using NBPhoneNumberUtil.sharedInstance instead of NBPhoneNumber()

simonmitchell commented 3 years ago

Ohh my god @duy-dindinn you saved me!!