Fix header import - Githubissues

iziz / libPhoneNumber-iOS

iOS port from libphonenumber (Google's phone number handling library)

Apache License 2.0

2.36k stars 464 forks source link

Fix header import #331

Closed olejnjak closed 3 years ago

olejnjak commented 3 years ago

It looks like merging #326 made libPhoneNumberGeocoding and libPhoneNumberShortNumber uncompilable. This effectively means that Carthage distribution have become useless as it always compiles all shared schemes.

This PR updates header imports to make all schemes compile again. If you can think about better solution I will be more than happy to help to make the project fully functional again.

calvarez-ov commented 3 years ago

Indeed, I've been having some problems building libPhoneNumberGeocoding in master, and this PR seems to fix the compilation errors.

rockebee commented 3 years ago

@olejnjak: Thx for finding and fixing this, I can confirm that the issue that showed up here also happened to me and that it got fixed with your commit.

@paween: As you have merged the troublesome PR #326, would you mind to also take a look on this very issue so it can (a) be merged to master and (b) ideally also be the base for a 1.0.3 release (cmp. other open PR #329)? What I haven't yet understood completely is why PR #326 got merged to master although the Travis test 738085136 failed?

olejnjak commented 3 years ago

Bad luck, feel free to add conditional import based on distribution so Cocoapods use different import than other distributions...