Fix SwiftPM support - Githubissues

bvirlet commented 3 years ago

Two fixes:

PackageDescription 4 doesn't support the platforms parameter, so it's incompatible with the annotation // swift-tools-version:4.1. Since you have a fine Package@swift-5.0.swift file, I have removed the platform parameters from Package.swift. I confirm that this fixes importing the package with SPM 5.3.
When importing the package, you can have duplicate symbol issues because variables are defined in the header file. I have declared them in the header file and moved the definition in the implementation file.

mnorth719 commented 3 years ago

Thanks for implementing this @bvirlet! I am having a similar issue and confirmed that your fix is working for me.

bvirlet commented 2 years ago

Hi @iziz. Do you plan to merge this? I have updated my fork with your latest changes (thanks) but the first commit is still needed to prevent the duplicate symbol issues. Thanks!

bvirlet commented 2 years ago

Reopened with the just the required commit #358

iziz / libPhoneNumber-iOS

Fix SwiftPM support #342