I wonder if it should be variance or sqrt(variance) here

izmailovpavel / understandingbdl

Other

231 stars 38 forks source link

I wonder if it should be variance or sqrt(variance) here #14

Closed alexlyzhov closed 2 years ago

alexlyzhov commented 2 years ago

https://github.com/izmailovpavel/understandingbdl/blob/5d1004896ea4eb674cff1c2088dc49017a667e9e/swag/posteriors/swag.py#L83

izmailovpavel commented 2 years ago

@alexlyzhov thank you, I think you are correct, it seems like this issue was introduced when we refactored the original SWAG code. Do you wanna submit a PR fixing it or should I just fix it?

alexlyzhov commented 2 years ago

PR: #15