izmailovpavel / understandingbdl

Other
229 stars 38 forks source link

SWAG Model #5

Closed jgbos closed 4 years ago

jgbos commented 4 years ago

The if statements have the same line. Is the first statement supposed to use swag_model instead of model?

https://github.com/izmailovpavel/understandingbdl/blob/34e21ad1f2c5c752deacb62e5f31d6c9145234ca/experiments/train/run_swag.py#L186

izmailovpavel commented 4 years ago

Hi @jgbos, thanks for looking into the code. The implementation is indeed redundant, but there is no error. This implementation was adapted from https://github.com/wjmaddox/swa_gaussian, where I believe we used this if statement at some point.