search

izofar / takes-a-pillage

A Pillager mod for 1.16.5, 1.18.2 & 1.19.2 aiming to expand on the pillager civilization, as well as provide additional challenges and compelling gameplay in the survival game mode.
MIT License
3 stars 8 forks source link

Compat with Villager-Armor-Layer #32

Open betterworld-sjq opened 7 months ago

betterworld-sjq commented 7 months ago

Describe the Suggestion

There's a mod https://www.curseforge.com/minecraft/mc-mods/villager-armor-layer making the armor layer of villagers, illagers, witches and some other mobs visible. That mod works well with the Archer, but not at all with Skirmisher. And the author of that mod says the Renderer must be extended from IllagerRenderer as to illagers to show their armor, but the Renderer of Skirmisher (https://github.com/izofar/takes-a-pillage/blob/1.18.2/src/main/java/com/izofar/takesapillage/client/renderer/SkirmisherRenderer.java#L16) is not in that way. So could you change the renderer type and make it compatible?

Screenshots and Videos

No response

Additional Context

No response

betterworld-sjq commented 7 months ago

Version 1.20.1 forge

Viola-Siemens commented 7 months ago

To give some more information, here's the original issue: https://github.com/Viola-Siemens/Villager-Armor-Layer/issues/6 Here's how the mod works to add armor layer to all illagers: https://github.com/Viola-Siemens/Villager-Armor-Layer/blob/dev/Forge-1.20-v5.0.X/src/main/java/com/hexagram2021/villagerarmor/mixin/IllagerRendererMixin.java#L22-L28