Open lima1756 opened 2 months ago
Thank you so much for this detailed feedback.
Regarding Feedback 3, sortString is the param variable used in defining the function. sortOption is the actual param input.
function newFunction(name){ console.log(name) } newFunction('Izuchukwu Mba')
In the above example, name would be sortString and 'Izuchukwu Mba' would be sortOption.
Great work with last week's project! The complexity jump from week 2 to week 3 was significant, so it's understandable that you weren't able to cover all the stretch goals. Nonetheless, great job completing everything else!
Fundamentals
For the sortBoards functionallity, if you see you have some kind of same code in all you cases like the
const data = await getBoards();
you could extract that at the beginning so it's more clear. Also, I noticed in this part of the code:I'm not sure I understand what's happening as the
sortString
is the input param, but in line 100 I see that the function is called with thesortOption
being that param, so this should be always true, right? If that's the case should we make it the final else?Security
Other