search

izuzak / atom-pdf-view

Support for viewing PDF files in Atom.
https://atom.io/packages/pdf-view
MIT License
106 stars 30 forks source link

Maintain scale to fit with pane resize #119

Closed OJFord closed 3 years ago

OJFord commented 8 years ago

~~Would be great to have:

  1. Command to scale to fit the PDF within pane
  2. Option to trigger this scaling to fit as pane is resized~~

PR 112 (already linked below) scales the PDF to fit the pane on load. It would be great to have this automatic on pane resizing.

izuzak commented 8 years ago

Thanks for opening an issue, @OJFord. To keep things simple -- can you please open another issue for the second feature and use this issue only for the first one (please edit the issue title and body)? One issue per feature request or bug report makes it much easier to maintain and track things.

OJFord commented 8 years ago

Sorry about that - my thought process was on implementation, that they could be the same request if the first was used by the second.

Went with item 2 for this issue, since in my opinion the PR above solves the same problem as item 1.

cbrnr commented 7 years ago

@OJFord but it would be nice to have a command "fit to width" so we can manually trigger this. There's no issue for this feature so I'll create one right now.

OJFord commented 3 years ago

I haven't used Atom for years and there's no other interest here; I'm struggling for context but it seems like the above merged PR addresses this 80% anyway, so, closing. 🙂