search

izuzak / atom-pdf-view

Support for viewing PDF files in Atom.
https://atom.io/packages/pdf-view
MIT License
106 stars 30 forks source link

Load deserializer early. Fixes #115. #121

Closed 314eter closed 8 years ago

314eter commented 8 years ago

This will need a small update to get it working with the new package.json format, but because that will break compatibility with atom's stable branch, I suppose we'll have to wait?

314eter commented 8 years ago

Works for latest stable and master now.

izuzak commented 8 years ago

Seems like there are more problems in Atom land related to this https://github.com/atom/atom/issues/10995. I'm going to hold of on merging this until that's resolved. Also, it seems that this pull request contains some unrelated changes. Can we keep this pull request focused on fixing #115 and leave other changes out?

314eter commented 8 years ago

I committed some unrelated changes by accident. They are reverted now.

izuzak commented 8 years ago

Sweet -- thanks for sticking with this, @314eter :zap:

izuzak commented 8 years ago

@314eter Looking forward to the followup PR which you mentioned here: https://github.com/izuzak/atom-pdf-view/pull/116#issuecomment-184020894

Also, I think I just noticed another problem. If I open several PDF files, then close Atom, then open Atom again -- all previously opened PDF files will be listed in tabs, but only the PDF file which was last focused before closing Atom will be correctly loaded while other PDF files will be blank. Wondering if you have an idea about why that's so. If not, I'll just open an issue to track this problem. :v:

314eter commented 8 years ago

Do you have the fitToWidthOnOpen option set? The clientWidth of unfocused tabs is 0, so the scale is set to 0. This should be fixed by #122.