search

izuzak / atom-pdf-view

Support for viewing PDF files in Atom.
https://atom.io/packages/pdf-view
MIT License
106 stars 30 forks source link

Object.TextEditor is deprecated. #127

Closed thomasjo closed 8 years ago

thomasjo commented 8 years ago

This might only be live on Atom master, but regardless I just got the deprecation warning below.

The TextEditor constructor is no longer public.

To construct a text editor, use atom.workspace.buildTextEditor(). To check if an object is a text editor, use atom.workspace.isTextEditor(object).

Object.TextEditor (/Users/thomasjo/Code/atom/atom/exports/atom.coffee:39:14)
Object.<anonymous> (/Users/thomasjo/.atom/packages/pdf-view/lib/pdf-editor-view.js:25:27)
Module._compile (/Users/thomasjo/Code/atom/atom/src/native-compile-cache.js:103:30)
Object..js (/Users/thomasjo/Code/atom/atom/src/compile-cache.js:208:21)
Module.load (module.js:356:32)
Function._load (module.js:313:12)
izuzak commented 8 years ago

Thanks for opening an issue, @thomasjo :blue_heart:

thomasjo commented 8 years ago

@izuzak No worries! I should have opened a PR with a fix, just never got around to it :bow: