search

izuzak / atom-pdf-view

Support for viewing PDF files in Atom.
https://atom.io/packages/pdf-view
MIT License
106 stars 30 forks source link

Printing support #162

Open recluze opened 7 years ago

recluze commented 7 years ago

I don't see any option to "Print" file -- or even to "Open with default viewer" (so that I can print from there).

Am I missing it or is it not there? If the latter, any plans to put it in please?

izuzak commented 7 years ago

Hi @recluze -- thanks for opening an issue.

Am I missing it or is it not there?

You're not missing anything -- it's not there.

If the latter, any plans to put it in please?

I don't have plans to add it myself since I don't have time to work on such a feature, but if someone else does -- that would be great and I'd be happy to review a pull request for such a feature.

recluze commented 7 years ago

Thanks for the quick response.

I don't have much experience with atom/js development but I'm willing to put in an effort (have a lot of other dev experience). Can you please guide me a bit about what you think might be a good strategy?

Usually when I see a pdf.js deployment, it comes built in with a top-bar that allows page navigation and printing etc. Maybe we can just enable that in pdf-view as well?

izuzak commented 7 years ago

I'm afraid I can't offer much guidance. As far as I know, Atom itself doesn't have a built-in print feature: https://github.com/atom/atom/issues/3525. And I haven't investigated what it would take to get the printing functionality from pdf.js enabled -- I only investigated what it would take to render PDF documents.

recluze commented 7 years ago

No issue. We can keep this open and I will see if I can come up with something. Any future readers might also shed some light on this.

jeffmcneill commented 6 years ago

There are several plugins that can print, such as: