search

izuzak / atom-pdf-view

Support for viewing PDF files in Atom.
https://atom.io/packages/pdf-view
MIT License
106 stars 30 forks source link

Workaround for #139, plus zooming issues on non-retina screens #182

Closed epimorphic closed 7 years ago

epimorphic commented 7 years ago

Not sure if this is the best way, but here's the workaround. Following the commit message:

1) Directly set context._transformMatrix in renderPdf() as a workaround for issue #139. 2) Removed the check if(outputScale != 1) so that scaling works better on non-retina screens. Zooming on a non-retina screen after moving the window from a retina screen used to change the resolution of the rendered image without also changing the size of the image on the screen (so for example zooming out would just make things blurrier). Moreover the original fix for #139 screwed up other elements in the document on non-retina screens without this additional change.

izuzak commented 7 years ago

Amazing! 😻 Thanks so much for fixing this, @epimorphic! ⚡️ 👏 ✨