izuzak / atom-pdf-view

Support for viewing PDF files in Atom.
https://atom.io/packages/pdf-view
MIT License
106 stars 30 forks source link

pdf-view can't approved Chinese path #194

Open xjtunk opened 6 years ago

xjtunk commented 6 years ago

When my path contains Chinese, the reserve to source can't success due to the unidentifiable Chinese code

izuzak commented 6 years ago

Thanks for opening an issue, @xjtunk :bow:

When my path contains Chinese, the reserve to source can't success due to the unidentifiable Chinese code

I'm not sure I understand what you mean by "reserve to source" -- what do you mean by that?

Do you see some error and if so -- which error do you see exactly?

Can you give an example path which has Chinese characters that causes problems for you?

xjtunk commented 6 years ago

I‘m sorry for my wrong expression. I mean that i want to double click the pdf so that i can go to the source. But when the path contains Chinese characters, like 'E:\北京大学\无线感知团队\论文写作\acmart-master', it will open a new pane, like E:\������ѧ\���߸�֪�Ŷ�\����д��\acmart-master\sample-acmlarge.tex. But when the path only contains English characters, it works well.

izuzak commented 6 years ago

Thanks for explaining, @xjtunk -- I think I understand now. Unfortunately, I'm not able to try and reproduce the problem since I don't have synctex installed anymore. Still, I do expect this is a bug in this package. If someone would like to try and reproduce and fix the problem -- I'd be happy to review a pull request!

Thank again for reporting this ⭐️

GitHubRulesOK commented 5 years ago

May be a redherring but traditionally synctex only stored latin characters without spaces, more recently some versions will support spaces and unicode but I think CJK may require/benefit from oriental W32TeX build rather than TeX Live. Thus I think pdf-view needs to pass back the path characters as unicode? possibly duplicate of #193

zhouzhouwei commented 5 years ago

Synctex does not work with Chinese text, when I delete the Chinese in the path, it works.