izuzak / atom-pdf-view

Support for viewing PDF files in Atom.
https://atom.io/packages/pdf-view
MIT License
106 stars 30 forks source link

Add basic URI handling #198

Closed yitzchak closed 6 years ago

yitzchak commented 6 years ago

This PR adds basic URI handling for the atom scheme which was added in v1.23. The main purpose is to handle SyncTeX forward requests from outside Atom and to support some of the Adobe PDF style URL parameters.

Currently supported is

Query parameters are allowed to exist in the hash in addition to the query portion since this is the Adobe PDF usage. A hash with no parameters is assumed to be a named destination. For example

There are more parameters listed here. I can add more if you are interested. I just added the ones that seem to me to be the most pertinent.

izuzak commented 6 years ago

Ohhhh, this sounds really neat -- thanks for adding this, @yitzchak, I'd be happy to add this to the package! I'll take a look over the weekend 👍

izuzak commented 6 years ago

Just tested this a bit and it worked great -- thanks again, @yitzchak! :bow: :zap:

yitzchak commented 6 years ago

@izuzak Provided I can avoid #200 in a new PR are you still willing to entertain this?

izuzak commented 6 years ago

@yitzchak Of course -- sorry for not clarifying that! Definitely interested in getting that merged into the package :+1: