search

izuzak / atom-pdf-view

Support for viewing PDF files in Atom.
https://atom.io/packages/pdf-view
MIT License
106 stars 30 forks source link

Feature request: Night mode switches with system dark mode #237

Open moritzpoll opened 3 years ago

moritzpoll commented 3 years ago

It would be great if the PDF Night Mode changed automatically when the machine shifts into night mode. Akin to feature request here and might be helpful to see how this was implemented in package auto-dark-mode.

izuzak commented 3 years ago

Neat idea! Thanks for the suggestion, @moritzpoll :bow: I probably won't have time to work on such a feature anytime soon, so I'd be open to reviewing and accepting a pull request to add this feature 👍

moritzpoll commented 3 years ago

Glad you like the idea! Afraid I don’t know the coding language for this, but maybe the night mode implementation in the package I mentioned is helpful for you (or anyone else who might want to give it a shot) if and when you get more time.

On 6. Apr 2021, at 17:12, Ivan Žužak @.***> wrote:

Neat idea! Thanks for the suggestion, @moritzpoll https://github.com/moritzpoll 🙇 I probably won't have time to work on such a feature anytime soon, so I'd be open to reviewing and accepting a pull request to add this feature 👍

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/izuzak/atom-pdf-view/issues/237#issuecomment-814443238, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM47WHOT4BSTRQGPI6W6GJ3THN2MDANCNFSM42FF4HEA.