search

izuzak / atom-pdf-view

Support for viewing PDF files in Atom.
https://atom.io/packages/pdf-view
MIT License
108 stars 30 forks source link

Speedup loading #38

Closed maxxk closed 9 years ago

maxxk commented 9 years ago

Improve startup time and activation time by requiring and constructing stuff as late as possible.

On my machine loading time dropped from 250ms to 34ms. Activation time is now ⩽5ms. It's still a lot, but I don't know how to speed it up further.

This pull request probably closes #37.

izuzak commented 9 years ago

@saidai-no Thanks for this! :zap: I just tried this out and it works great + brings down the loading time :heart:

I did notice one problem, though. If I open a PDF file, then quit Atom, and then re-start Atom -- the PDF file I opened before quitting Atom is gone from the list of open files (it's not shown in the tabs). Are you seeing the same behavior perhaps? I'm on OSX 10.10.1, Atom 0.159.0-d9a5e3c.

maxxk commented 9 years ago

Atom had been very unpredictable for me in keeping tabs open across the restart, so I didn't notice this. It should be fixed in the last commit :) I don't think there is any more elegant simple way to preserve open tabs and reduce loading time.

izuzak commented 9 years ago

This is great! Thanks again so much for the PR :zap: