izuzak / atom-pdf-view

Support for viewing PDF files in Atom.
https://atom.io/packages/pdf-view
MIT License
106 stars 30 forks source link

mouse-based panning & zooming, SyncTeX support #81

Closed autc04 closed 8 years ago

autc04 commented 8 years ago

Here are two things I hacked up because I wanted them for myself; I'm not sure how they fit with your idea of what atom-pdf-view's feature set should be.

The two features interact slightly because the SyncTeX behaviour is suppressed when the mouse moved during the click; they can easily be separated if you want to include one but not the other.

izuzak commented 8 years ago

Hey, @autc04! Thanks for opening a pull request :green_heart:

I'd be interested in adding these features. Before reviewing, could I trouble you to split this pull request into two smaller pull requests, one for each feature? That will make reviewing, testing and merging a bit easier since the features are mostly independent.

You mentioned that the features do interact a bit, so perhaps we could start with a pull request for "panning & zooming with the mouse.", and then open a pull request for SyncTeX support once that is in? :thought_balloon:

autc04 commented 8 years ago

done. autc04-mousepan can now be reviewed first.

autc04 commented 8 years ago

I'll add some more polish and reopen soon.