search

izuzak / atom-pdf-view

Support for viewing PDF files in Atom.
https://atom.io/packages/pdf-view
MIT License
108 stars 30 forks source link

SyncTeX support #87

Closed autc04 closed 9 years ago

autc04 commented 9 years ago

SyncTeX support is now ready for review.

izuzak commented 9 years ago

:zap: @autc04 :zap:

Just tried this out and works great -- thanks so much for adding this. I did notice one small problem, however -- when I click on a line in the PDF, the .tex file for that PDF is opened correctly, but the cursor is positioned on the line following the one it should be positioned on (i.e. if I clicked on line N, cursor is positioned on N+1). Any chance there's an off-by-one error somewhere (or a difference in how lines are indexed, 1-based vs 0-based)? Are you seeing the same or do you see correct behavior?

autc04 commented 9 years ago

Indeed. The fact that a text editor that would inflict 1-based column numbers on me in the UI would use 0-based line numbers in the API caught me off guard.

izuzak commented 9 years ago

:sparkling_heart: Just published a new version with this -- thanks again!

olmokramer commented 9 years ago

Amazing work @autc04! Thank you very much! :)