search

izuzak / atom-pdf-view

Support for viewing PDF files in Atom.
https://atom.io/packages/pdf-view
MIT License
106 stars 30 forks source link

Quote filenames containing whitespace in argument to SyncTeX if called via 'exec'. #95

Closed xax closed 8 years ago

xax commented 8 years ago

See issue #91.

This patch is not thoroughly tested, as I do not have the opportunities to do that right now (– that being the reason I opened an issue instead of posting a pull request in the first place).

And you can think of other approaches to tackle the issue, too: Unconditionally quote, quote entire clickspec argument, quote upon other characters as well…

l0calh05t commented 8 years ago

It would be better to just shell escape clickspec in its entirety. That way only the exec version would be affected by the code changes. node-shell-escape could be used for this purpose (although it might not be suitable for windows.. linux and windows escaping are different).

izuzak commented 8 years ago

Thanks for opening a pull request. :cake: I cleaned this up a bit and merged.