search

izzyreal / vmpc-juce

JUCE implementation of VMPC2000XL
GNU General Public License v3.0
91 stars 7 forks source link

Build error on Fedora 40 with gcc 14.2.1 #106

Closed ycollet closed 3 months ago

ycollet commented 3 months ago

I am trying to build vmpc on Fedora 40 with gcc 14.2.1 and I meet a build error:

In file included from /builddir/build/BUILD/vmpc-juce-0.6.1/editables/mpc/src/main/lcdgui/Screens.cpp:166:
/builddir/build/BUILD/vmpc-juce-0.6.1/deps/rapidjson/include/rapidjson/document.h: In member function ‘rapidjson::GenericStringRef<CharType>& rapidjson::GenericStringRef<CharType>::operator=(const rapidjson::GenericStringRef<CharType>&)’:
/builddir/build/BUILD/vmpc-juce-0.6.1/deps/rapidjson/include/rapidjson/document.h:319:82: error: assignment of read-only member ‘rapidjson::GenericStringRef<CharType>::length’
  319 |     GenericStringRef& operator=(const GenericStringRef& rhs) { s = rhs.s; length = rhs.length; }
      |                                                                           ~~~~~~~^~~~~~~~~~~~
izzyreal commented 3 months ago

Good find @ycollet, thanks for the report. I've updated the revision of the rapidjson dependency that is used in https://github.com/izzyreal/mpc from v1.1.0 (published in 2016) to master. It should now include https://github.com/Tencent/rapidjson/pull/719, which fixes the issue you mentioned. Can you try to build again? You may need to wipe editables/mpc before doing so.

ycollet commented 3 months ago

First test seems to work now. I close the ticket and thanks a lot for your quick answer !