j-andrews7 / kenpompy

A simple yet comprehensive web scraper for kenpom.com.
https://kenpompy.readthedocs.io/en/latest/?badge=latest
GNU General Public License v3.0
73 stars 21 forks source link

Enhancements merge from dev to master #46

Closed esqew closed 1 year ago

esqew commented 1 year ago

The nice-to-have enhancements I've been working on sporadically in dev are ready for primetime.

I'm holding this in draft until the season ends April 3rd to minimize any potential workflow disruption (if any at all), unless there is an identified need to push any of this sooner.

esqew commented 1 year ago

Also, please forgive my poor Git hygiene. 😬

I'm a bit rusty due to my day job's involvement in a platform with rather nonconventional SCM.

j-andrews7 commented 1 year ago

Man, I work in science. The fact you use commit messages or any version control and are capable of writing a docstring or adhering to the same basic style is a damn delight compared to most stuff I stare at on a daily basis.

I do not care if you use a new commit for every line changed, and that's really not even much of an exaggeration. As always, I appreciate the help.

esqew commented 1 year ago

The fact you use commit messages or any version control and are capable of writing a docstring or adhering to the same basic style is a damn delight compared to most stuff I stare at on a daily basis.

Can't begin to describe how much this resonates with me as well, haha! Appreciate the response - hope all is well on your end.

esqew commented 1 year ago

Happy offseason! Taking a little bit more time to do a few quick checks before I merge this to master this week.

(Also - congratulations to the UConn Huskies!)