Fixed shape test for test_get_program_ratings after patch to remove extraneous rows

j-andrews7 / kenpompy

A simple yet comprehensive web scraper for kenpom.com.

https://kenpompy.readthedocs.io/en/latest/?badge=latest

GNU General Public License v3.0

70 stars 21 forks source link

Fixed shape test for test_get_program_ratings after patch to remove extraneous rows #51

Closed esqew closed 1 year ago

esqew commented 1 year ago

The test broke in the last push to master. Not sure how this slipped by my numerous tests and CI/CD, but updating to expect 356 rows in accordance with what displays on the target page.

esqew commented 1 year ago

I just realized that there are actually 357 teams on https://kenpom.com/programs.php, even though there are 356 in the resulting DataFrame. Going to close this while I investigate further why this isn't lining up.

esqew commented 1 year ago

Never mind! Not sure what happened on KenPom's side, but there are indeed 356 teams but 357 ranks; seems his list skips one...