j-andrews7 / kenpompy

A simple yet comprehensive web scraper for kenpom.com.
https://kenpompy.readthedocs.io/en/latest/?badge=latest
GNU General Public License v3.0
70 stars 21 forks source link

Fixed team schedules before 2010 #75

Closed WakeUpWaffles closed 9 months ago

WakeUpWaffles commented 10 months ago

Originally was looking into #68, but seems to all ready be handled after creating tests. It is handled by this code: https://github.com/j-andrews7/kenpompy/blob/a30590ba57cfb004ac1bbad3b27099f4b9110906/kenpompy/team.py#L74-L77

However, I found an issue with team's schedules not having a rank column 2010 and earlier. Added logic to handle the missing column.

test_team.py test coverage now includes:

j-andrews7 commented 10 months ago

Yeah, seems like a good idea. I will try to roll all the PRs in by the end of the week to get a release out to fix most of the outstanding issues.