search

j-andrews7 / kenpompy

A simple yet comprehensive web scraper for kenpom.com.
https://kenpompy.readthedocs.io/en/latest/?badge=latest
GNU General Public License v3.0
70 stars 21 forks source link

add NST% columns #89

Closed nickostendorf closed 7 months ago

nickostendorf commented 7 months ago

New column mapping for get_teamstats(). Added missing NST% and NST% Rank

Before, A% and 3PA% were getting populated with the wrong values, and AdjOE values would not be present.

image

j-andrews7 commented 7 months ago

Thanks, Nick. Any chance you also want to update the few tests for this?

nickostendorf commented 7 months ago

Hey Jared, the test_get_teamstats(browser): seems to already include the NST% & Rank columns.

image

def test_get_teamstats(browser):
    expected = ['Louisville', 'ACC', '34.2', '177', '50.6', '161', '77.7', '8', '10.6', '272', '8.3', '101', 
               NST --> '9.2', '128', '53.6', '122', '43.7', '56']

Let me know if we would still want a separate test on just the NST value and rank.

j-andrews7 commented 7 months ago

Oh, good look. Note sure how/when this got goofed then. I'll make a new release when I get a chance, thanks.