search

j-be / AutoBim

A bed tramming utility for OctoPrint using ABL
Other
29 stars 3 forks source link

G30 coordinates ignoring probe offset #25

Closed charredchar closed 2 years ago

charredchar commented 2 years ago

I am running Klipper, BLTouch is set up correctly with the X and Y offsets, following the Klipper documentation and Bed_Mesh works as expected. Added the G29 and G30 Macros to my Klipper config, both seem to respond to commands without an error.

When running through the Preparation section I used G0 X150 Y150 for the middle of the bed. When issuing the G30 X150 Y150 it does not move the probe over to the location of the nozzle, instead it probes in the same spot. If I was to issue G30 X183 Y139 to take into account my probe offset it moves to where I expect.

j-be commented 2 years ago

Hi, thanks for the feedback.

This is a known limitation. It is not an issue with the plugin itself, but with the G30 macro in the README.md. Marlin's G30 already factors in the offset, so the plugin was never developed with that in mind.

The Klipper macros were not written by me, and I still don't have Klipper up and running, so I can't really help here. From what I can tell the macro in the README.md uses G1 (which is "move nozzle") and does not factor in the offset, which I agree that it should. So if you find a working approach I'd be more than happy to add it to README.md.

If not, I'd recommend you just factor in the offsets when setting the points in the settings for now. Maybe I'll come back to it when (not sure when that will be the case - if ever) I have Klipper up and running.

In any case: please leave this issue open for now - I should at least add a warning to the README about this.

datapaganism commented 2 years ago

fixed as of commit https://github.com/j-be/AutoBim/commit/8ae2b5d25105c85ed636359a347e16844e0218b8, @j-be please close this issue thanks.

j-be commented 2 years ago

@datapaganism Thanks, did not think of this.

For reference: This is was fixed with #29.