j-bennet / wharfee

A CLI with autocompletion and syntax highlighting for Docker commands.
BSD 3-Clause "New" or "Revised" License
657 stars 41 forks source link

Crash at processing explanation from APIError. #148

Closed rockwelln closed 7 years ago

rockwelln commented 7 years ago

Trying to pull an unknown repo triggers an APIError from docker-py. The explanation text is not correctly interpreted by docker-py (this is already fixed in the current master of docker-py/errors.py, but not yet released). Anyway, the explanation text is made with bytes, which provoke a crash:

$ wharfee Version: 0.10 Home: http://wharfee.com wharfee> pull mo sequence item 0: expected str instance, bytes found Goodbye! $

Turning the explanation into str, avoid the crash and should prepare the next release of docker-py.

j-bennet commented 7 years ago

Looks good. Merging. 🍫