search

j-bennet / wharfee

A CLI with autocompletion and syntax highlighting for Docker commands.
BSD 3-Clause "New" or "Revised" License
657 stars 41 forks source link

Update for docker-py 2.x.x. #156

Closed yoshiya-hirase closed 7 years ago

yoshiya-hirase commented 7 years ago

Support docker-py 2.x.x. AutoVersionClient method is no longer available in docker-py 2.x.x. This modification calls the right API to get docker client according to docker-py version.

j-bennet commented 7 years ago

@yoshiya-hirase You missed one instance of AutoVersionClient in client.py, line 131. I think this will work once you fix that.

Thanks for the PR! I neglected wharfee for a long time, because it didn't seem to gain much of a user base. It's definitely time to switch it to newer docker-py. The tests are failing because an ubuntu package is now outdated also. I'll see if I can fix that.

yoshiya-hirase commented 7 years ago

@j-bennet thanks for your feedback. It is right that I missed the modification by my mistake. I fixed it as you pointed. That is very nice that you will work for latest docker to support. Before then, hope this fix be nice for someone who would like to use your nice work:).

yoshiya-hirase commented 7 years ago

Fixed one more mistake in a test code resulting in successful CI.

j-bennet commented 7 years ago

Thanks for the PR!

🍫