search

j-brant / SmaCC

MIT License
24 stars 16 forks source link

SmaCC_Elixir Missing identifiers #33

Open mariari opened 3 weeks ago

mariari commented 3 weeks ago

The Elixir source isn't great at explaining what all the identifiers are in the source. Thus a lot of them go undefined.

The code to properly understand it can be seen here:

https://github.com/elixir-lang/elixir/blob/f38895cebba0fa06f686e1dd9b74e5729aebcb45/lib/elixir/src/elixir_tokenizer.erl

What is missing are:

in #28 I define dot_call_op properly However I fail to properly address 1-4.

2-3 are easy enough as they just need to either peek ahead, or reset the stream to being 1 character back while dropping their parsed ( or [.

4-5 I'm unsure how to handle.

j-brant commented 3 weeks ago

If you look at ElixirParser>>#actionsForCurrentToken, you can see that they are defined.

mariari commented 2 weeks ago

If you look at ElixirParser>>#actionsForCurrentToken, you can see that they are defined.

Thanks I somehow missed that when looking over things.

Are there good ways for testing when rules for this go off (I'm going to just invoke a DNE message in where it applies to see it in action)? I may have found an issue with it (Commented in #32).