search

j-cob44 / max-hit-calc

Runelite plugin which automatically calculates stats about max hit and displays to the player.
https://runelite.net/plugin-hub/show/max-hit-calculator
BSD 2-Clause "Simplified" License
2 stars 1 forks source link

Style based miscalcs/display error #21

Closed Watevir closed 7 months ago

Watevir commented 8 months ago

Max hit shown for Melee does not appear to take into account style bonuses correctly, always calculates as though player is on aggressive. This can be seen using full obsidian armour with splitsword zerker necklace and ring with rune boots/regen brace at 60str with a divine str potion. max hit calcs as 23 but it is only 23 with aggressive style and is instead 22 on defensive/accurate styles with above mentioned stats/gear

j-cob44 commented 8 months ago

Hey @Watevir!

Is this happening when you mouse over the item in your inventory, but correct once the item is equipped?

Watevir commented 8 months ago

It's happening while things are equipped

j-cob44 commented 8 months ago

Could you send a picture of your equipment screen when the problem is happening? I'll look into this and see if I can fix it for next update!

Kubia-Beta commented 8 months ago

Can't tell if this is the same issue causing this. Real max hit is 14, estimated 13 (spec is off too, should be 21, says 19). Was on Pummel (Aggressive)(Crush)(Str). Tooltip says the next max is in: 3str levels, 6str bonus, 6% prayer boost. Plugging this gear into a calculator, the calculations would be if I was on Accurate, but I am not. Switching styles has no effect. wrong max hit

wrong max hit pt2 wrong max hit pt3

I was able to replicate the issue on the same setup as the images, but with a rune scimitar instead of a dragon mace. It again did not update the values for the prayer/str bonus/str levels when changing styles. With a rune scim, the max hit does not change, but on chop (accurate) it correctly lists 4 levels to next max, and on slash (aggressive) it says the same despite it actually taking only 1 max.

From equipping different items, it seems that the inventory max is overvalued while equipped is undervalued. This is true for multiple styles. When I pull out my two Rune Crossbows and Bronze Bolts, the one I have equipped gets a max hit of 8 on the calculator while the one in my inventory has a max hit of 9 on the same report. Very interestingly, it says I will gain a max hit in 2 levels, 2 bonus or 4% bonus. I actually gain a max hit with 5 bonus or 5 ranging levels.

In both cases, there appears to be a +3 bonus somewhere. So, I tried stripping to just the dragon mace with my iron's stats. It then said I needed 6 more strength bonus/levels, which is very odd because I would need 3. With an entirely naked character, it then reports that the mace in inventory maxes a 14 (not a 12) which is 14 strength bonus off. I'm not really sure what's going on here, since that's a helluva jump. Only something like the attack style mult being wrongly applied multiple times should even come close.

j-cob44 commented 8 months ago

Hi @Kubia-Beta, from the pictures you've provided, you are using a different plugin than this one I have made. I believe you are using an old plugin that is no longer updated. Please try mine out! https://runelite.net/plugin-hub/show/max-hit-calculator

How I know this is true is that my plugin does not show decimals, image and the setting page currently looks like this, image

j-cob44 commented 8 months ago

I'm not sure if this is both of your cases. @Watevir, please let me know if your issue still persists and if so, please post some screenshots of the issue.

j-cob44 commented 7 months ago

Hi @Watevir,

I've been trying to replicate this issue and I still am unable to. Please ensure you are using my plugin, here is a screenshot of it in the external plugin section of Runelite.

image

I believe you are using the older, outdated plugin which has not been updated for a few years now.