search

j-cob44 / max-hit-calc

Runelite plugin which automatically calculates stats about max hit and displays to the player.
https://runelite.net/plugin-hub/show/max-hit-calculator
BSD 2-Clause "Simplified" License
2 stars 1 forks source link

Max hit doesn't take into account invisble bonus from combat style #4

Closed GwenTheKween closed 1 year ago

GwenTheKween commented 1 year ago

I am exactly on a point where depending on the combat style, I get 1 extra max hit. My current setup is: 30 strength, adamant mace.

When I use the accurate, controlled or defensive style, my max hit is (correctly) reported as 5. However, because of the invisible +3 boost to strength with the aggressive style, my max hit becomes 6, and the plugin does not change. I imagine that the same bug would happen if I was 32 strength and using the controlled style, but I having gotten there yet to verify :p

j-cob44 commented 1 year ago

Thanks for the report, going to start looking into this. Can you confirm what your max hit is with nothing equipped and what the inventory tooltip says when hovering over the adamant mace to equip it?

j-cob44 commented 1 year ago

I've been trying my best to replicate this and can't yet. On the main panel, does the display end in a decimal or is it just a whole number?

image

GwenTheKween commented 1 year ago

it ends with the decimal. I'll check my max hit without equipments in a moment, once I'm done with work

j-cob44 commented 1 year ago

Gotcha! So the decimal ending version is not my plugin, that plugin is called Max Hit by Matt 12 year. My version is called Max Hit Calculator, check it out on the plugin hub! My version fixes all of those small calculation inaccuracies.

GwenTheKween commented 1 year ago

Ah alright. Sorry about the bogus bug report then

j-cob44 commented 1 year ago

No worries! Check out my plugin and let me know what you think. The style bonus will show on it!