Ci workflow - Githubissues

j-d-carmichael / boats

Beautiful Open Api Template System

MIT License

57 stars 8 forks source link

Ci workflow #26

Closed p-mcgowan closed 4 years ago

p-mcgowan commented 4 years ago

Removed travis for github actions
- runs build, lint, test, format
Added prettier (npm run format)
Ran format and lint. I would recommend looking through ae173dd, 136f171, and 42dde80 separately as the lint and format commit is a big one (23d6338). 42dde80 is a minor refactor as a result of lint complaining, but it made sense to split it out for review.

j-d-carmichael commented 4 years ago

All looks ok except the comment above - but if the tests pass all good.

p-mcgowan commented 4 years ago

Would love to get rid of those hash tests when we have enough coverage from content tests - I'm guessing they failed because of a change in the tpls, but I have no idea.

However, no test should exist which can pass on master one day and fail later.

So far, I'm pretty happy with the coverage in __tests__/buildFiles.spec.ts - it just checks that every key and value that should be there exists on the yaml - we could go a step further and check the whole object for parts that were not there before,

p-mcgowan commented 4 years ago

ok I went a step further - tests now match the exact api object - so any new or missing lines / keys / values whatever, those will fail the tests.

Removed the hash tests because they don't offer anything at this point, and can break when nothing changes (not great for CI).