search

j-d-carmichael / boats

Beautiful Open Api Template System
MIT License
57 stars 8 forks source link

feat: Generate easier to read plural names (Fancy Pluralization). #52

Closed zewish closed 3 years ago

zewish commented 3 years ago

Example: "Universitys" should now become "Universities".

j-d-carmichael commented 3 years ago

Looks good - 2 points:

1 - I moved the docs from gh-pages to a subdir named docs. Could you add to the docs readme some docs about this feature please.

2 - src/utils/buildIndexFromPath.ts is where the main work is happening, could we get a small unit test on the pluralisation checks either by extracting the pluralisation from the file to its own helper or testing the whole buildIndexFromPath?

p-mcgowan commented 3 years ago

noice