search

j-d-carmichael / boats

Beautiful Open Api Template System
MIT License
57 stars 8 forks source link

Version check takes a long time to timeout on runner with no internet #78

Closed gabormagyar closed 1 year ago

gabormagyar commented 1 year ago

Version check takes 5 minutes or more to timeout if boats is run on a CI runner with no internet access.

There should be an option to disable the version check entirely, not just the user interaction.

In the meantime I'm going to use patch-package as a workaround to remove the version check.

p-mcgowan commented 1 year ago

@gabormagyar as another option, if you set NODE_ENV=test the checker is skipped entirely

gabormagyar commented 1 year ago

NODE_ENV can affect quite a few things so I'd rather not use it in production

j-d-carmichael commented 1 year ago

Maybe the best solution would be a cli option that bypasses the version check.

To advertise the option, it would be output to the console when the check is in progress.

j-d-carmichael commented 1 year ago

Alrighty, pass -n and it will skip version check or --noVersionCheck in version 3.4 just released