j-delaney / back-to-backspace

https://chrome.google.com/webstore/detail/back-to-backspace/cldokedgmomhbifmiiogjjkgffhcbaec

MIT License

45 stars 14 forks source link

Update inject.js #15

Closed OlsonDev closed 8 years ago

OlsonDev commented 8 years ago

nodeName is always uppercase for HTML elements; slight performance & readability improvement
Chrome has had support for Array.prototype.includes since Chrome 47; since this is a Chrome-only extension, use it without worrying about cross-browser compatibility

See http://ejohn.org/blog/nodename-case-sensitivity/ & https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/includes#Browser_compatibility

Thanks for putting this project/extension together!

j-delaney commented 8 years ago

Sorry for leaving this PR untouched for so long, I've been busy the past couple of days. I'll test this out and merge it this weekend. Thanks for your patience and help :)

j-delaney commented 8 years ago

17 included your changes. Thanks for submitting them and I'm really sorry about taking so long to do anything. Started at a new job and I've been really busy the past few weeks.