search

j-delaney / back-to-backspace

https://chrome.google.com/webstore/detail/back-to-backspace/cldokedgmomhbifmiiogjjkgffhcbaec
MIT License
45 stars 14 forks source link

replace browser sniffing with manifest field #21

Closed oslego closed 8 years ago

oslego commented 8 years ago

The Chrome Extension manifest has an optional field called "minimum_chrome_version". With that set, Chrome will allow the extension to be installed and run only on versions equal and above the given value.

This PR replaces Chrome version sniffing with the manifest field. Cleaner code ;)

j-delaney commented 8 years ago

Awesome! Unfortunately, merging in other PRs has made this incompatible. Once it doesn't have conflicts I'd love to merge it in.

Also, the reason I originally didn't use "minimum_chrome_version" was because I wanted people to be able to install the extension before the change to backspace happened so it would be a seamless transition for them.

oslego commented 8 years ago

Fixed the merge conflict.

j-delaney commented 8 years ago

Wonderful! Thanks for the PR :)