search

j-delaney / back-to-backspace

https://chrome.google.com/webstore/detail/back-to-backspace/cldokedgmomhbifmiiogjjkgffhcbaec
MIT License
45 stars 14 forks source link

Throws js exception #23

Open MattShaile opened 8 years ago

MattShaile commented 8 years ago

With the developer tools open and "pause on exceptions" ticked, every web page throws an exception upon load

OlsonDev commented 8 years ago

What's the exception? I'm not able to reproduce this.

MattShaile commented 8 years ago

Sorry I had uninstalled it by the time I posted this issue. I've reinstalled it now, the exception is:

inject.js:13 Uncaught TypeError: Cannot read property '1' of null(anonymous function) @ inject.js:13

Seems to be a problem around this line: https://github.com/j-delaney/back-to-backspace/blob/master/src/inject/inject.js#L13

OlsonDev commented 8 years ago

Are you using Chrome? Which version? OS?

MattShaile commented 8 years ago

Found when using this chrome extension: https://chrome.google.com/webstore/detail/back-to-backspace/cldokedgmomhbifmiiogjjkgffhcbaec

I'm on Windows 10, Chrome version 52.0.2743.116 m

OlsonDev commented 8 years ago

Interesting. Same here. If you go to the console and output navigator.userAgent, what do you get?

MattShaile commented 8 years ago

Sorry, just noticed I had emulator mode on and was simulating an iPad. That's a crucial piece of information, as it works fine when you're not in emulator mode or if you emulate a nexus.

OlsonDev commented 8 years ago

Ah. Good to know. I can't see why pull request #21 wouldn't fix your issue when @j-delaney gets time to merge it.