j-easy / easy-rules

The simple, stupid rules engine for Java
https://github.com/j-easy/easy-rules/wiki
MIT License
4.86k stars 1.05k forks source link

org.jeasy.rules.core.DefaultRulesEngine.java NullPointerException #329 #330

Closed aston2016 closed 3 years ago

fmbenhassine commented 3 years ago

Thank you for raising this issue and opening this PR 👍 I think we need to add null checks for rules and facts parameters in the check and fire methods. The same issue would happen in InferenceRulesEngine which I fixed in 8109230ca08adbc69d9a889cf80e399247652b79. Don't hesitate to add your name to the contributors list in the README as well! Thank you upfront.

aston2016 commented 3 years ago

Thank you for your reply. I will resubmit later. I wish you a happy Chinese New Year.