Thank you for your PR. However, it contains a lot of unrelated changes (add lombok, add new enum, add a new composite rule implementation, modify assertions, etc) and it is not easy to review.
If you want to contribute to a project and unless your contribution is trivial, I recommend you first open an issue and see if the project maintainers are ready to accept your contribution (for example, I'm not interested in introducing lombok here). This will save time for everyone and especially your time.
I really appreciate your effort here, but I'm closing this PR as I can't merge it as such. You are welcome to contribute to the project if you want, but try to do it one change at a time with more focused issues/PRs.
Hi,
Thank you for your PR. However, it contains a lot of unrelated changes (add lombok, add new enum, add a new composite rule implementation, modify assertions, etc) and it is not easy to review.
If you want to contribute to a project and unless your contribution is trivial, I recommend you first open an issue and see if the project maintainers are ready to accept your contribution (for example, I'm not interested in introducing lombok here). This will save time for everyone and especially your time.
I really appreciate your effort here, but I'm closing this PR as I can't merge it as such. You are welcome to contribute to the project if you want, but try to do it one change at a time with more focused issues/PRs.
Thank you for your comprehension.