search

j-f1 / eslint-docs

Keep your rule names and descriptions up-to-date across your repo
https://j-f1.github.io/eslint-docs
ISC License
3 stars 3 forks source link

fix: allow to use scoped package names in same way as they are handled in eslint #39

Closed armano2 closed 5 years ago

armano2 commented 5 years ago

this PR contains function extracted from eslint: https://github.com/eslint/eslint/blob/6009239042cb651bc7ca6b8c81bbe44c40327430/lib/util/naming.js#L69

its best if its going to use same logic to generate package name as eslint to limit potential issues with other packages

fixes: #38

codecov[bot] commented 5 years ago

Codecov Report

Merging #39 into master will increase coverage by 0.86%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   92.68%   93.54%   +0.86%     
==========================================
  Files           5        6       +1     
  Lines          82       93      +11     
  Branches       19       23       +4     
==========================================
+ Hits           76       87      +11     
  Misses          6        6
Impacted Files Coverage Δ
src/package-name.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 03e6da0...6adb56a. Read the comment docs.

armano2 commented 5 years ago

Do I have to do something here¿

j-f1 commented 5 years ago

Do I have to do something here¿

Nope, just didn’t have a chance to review this. Sorry for the delay!

armano2 commented 5 years ago

can i merge this?