Makefile colors are buggy on some terminals

j-faria / kima

Exoplanet detection in RVs with DNest4 and GPs

http://www.kima.science

MIT License

15 stars 10 forks source link

Makefile colors are buggy on some terminals #43

Closed j-faria closed 6 years ago

j-faria commented 6 years ago

No idea how to test for this...

jdavidrcamacho commented 6 years ago

Maybe it's because of the palette some people might use in the terminal, not really your fault if its due to that :\

j-faria commented 6 years ago

I agree, but we should still fallback to something that looks ok. I mean, not this

\033[0;33m Compiling example \033[0m BL2009

eggplantbren commented 6 years ago

I'm affected by this issue. Why do we need color at all?

j-faria commented 6 years ago

Because it looks fancy, is my only argument ¯\_(ツ)_/¯

eggplantbren commented 6 years ago

:-)

On Tue, 19 Jun 2018, 8:01 PM João Faria, notifications@github.com wrote:

Because it looks fancy, is my only argument ¯(ツ)/¯

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/j-faria/kima/issues/43#issuecomment-398310626, or mute the thread https://github.com/notifications/unsubscribe-auth/ABgVOlLPvhDWzD05qX7UYgiFRmnzX2pQks5t-K-8gaJpZM4Ukir2 .