j-faria / kima

Exoplanet detection in RVs with DNest4 and GPs
http://www.kima.science
MIT License
15 stars 10 forks source link

Non-standard and risky use of global variables #45

Open eggplantbren opened 6 years ago

eggplantbren commented 6 years ago

This doesn't seem to affect the functionality, and I have run kima through a valgrind check and it passes. So it is only an issue of C++ style. There are some strange uses of new to create variables on the heap and it's not clear where they get deleted. There is almost certainly a better way to manage these things.