search

j-faria / kima

Exoplanet detection in RVs with DNest4 and GPs
http://www.kima.science
MIT License
15 stars 10 forks source link

Request to set a prior on Tc for a known monotransit planet of unknown period #80

Closed accameron closed 3 months ago

accameron commented 9 months ago

At present the use of a prior on orbital phase derived from the time of conjunction,Tc, requires the orbital period to be specified as a parameter of make_prior

In the case of a known monotransit planet it would be very useful if users could set a prior on the time of conjunction Tc (say KO_Tcprior) while allowing an uninformative prior on the orbital period, as an alternative to setting a prior on the mean anomaly at the time of the first observation. For any individual sample, phi could then be calculated from the current samples of P, Tc, e and omega.

j-faria commented 9 months ago

Hi Andrew! Indeed, this would be quite useful. I'm thinking of creating a transiting_planet akin to the known_object but which is parameterised directly with Tc instead of the mean anomaly phi. This would then work for mono/duo/multi transits in general.

accameron commented 9 months ago

Hi João

That would be great! Let me know if you need a beta-testing volunteer when you get around to implementing it.

Cheers

Andrew

On 6 Dec 2023, at 10:52, João Faria @.***> wrote:

Hi Andrew! Indeed, this would be quite useful. I'm thinking of creating a transiting_planet akin to the known_object but which is parameterised directly with Tc instead of the mean anomaly phi. This would then work for mono/duo/multi transits in general. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.> [ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/j-faria/kima/issues/80#issuecomment-1842635680", "url": "https://github.com/j-faria/kima/issues/80#issuecomment-1842635680", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.***": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

% ----------------------------------------------------------------------- % Andrew Collier CAMERON, FRSE % Professor of Astronomy % Centre for Exoplanet Science / SUPA, School of Physics & Astronomy % University of St Andrews, North Haugh ST ANDREWS, Fife, KY16 9SS % Tel: +44-1334-463147
% Fax: +44-1334-463104 % @.***
% http://star-www.st-and.ac.uk/~acc4/

% The University of St Andrews is a charity registered in Scotland : % No SC013532 %
———————————————————————————————————

karenacollins commented 7 months ago

Yes, I could really use the Tc prior capability too for mono/duo transit work.

j-faria commented 3 months ago

Hi @accameron, @karenacollins, The ability to set a prior for $T_c$ is now implemented in the new version of kima that can be found here. There is also a worked through example in the documentation.

I will close this issue for now, but please let me know if you run into any issues with the new version.

karenacollins commented 3 months ago

Thank you!