rearranging subscriptions duplicates subscription list

alotbsol555 commented 3 months ago

Checklist

[X] I am able to reproduce the bug with the latest version.
[X] I made sure that there are no existing issues - open or closed - which I could contribute my information to.
[X] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
[X] This issue contains only one bug, that only occurs in Squawker

Affected version

3.7.8

Steps to reproduce the bug

rearrange subscriptions (to see the bug more easily, rearrange something towards the end of the list)
stay in the subscription list

Expected behavior

Having a single rearranged list of subscriptions.

Actual behavior

after rearranging, the rearranged list is added completely as duplicate to the list each time you rearrange something, i.e. you can scroll down past the previous end of ths list. leaving the list and coming back to subscriptions shows the correct, rearranged list only once.

Screenshots/Screen recordings

No response

Logs

No response

Affected Android/Custom ROM version

Android 14

Affected device model

No response

Additional information

No response

j-fbriere commented 3 months ago

Sorry but I cannot reproduce. The tests I did:

1- First test:

Rearrange a couple of subscription items around the top
Scroll down and up
Go to Feed and return to Subscriptions
Scroll down and up
Close and reopen the app
Go to Subscriptions
Scroll down and up

2- Second test:

Rearrange a couple of subscription items from around the top to around the bottom
Scroll down and up
Go to Feed and return to Subscriptions
Scroll down and up
Close and reopen the app
Go to Subscriptions
Scroll down and up

3- Third test:

Rearrange a couple of subscription items from around the bottom
Scroll down and up
Go to Feed and return to Subscriptions
Scroll down and up
Close and reopen the app
Go to Subscriptions
Scroll down and up

It always stayed with one and only one Subscription list.

Please give me specific steps to reproduce.

Note: In theory if you click on the ordering type or ordering order icons, it removes the custom reordering. You should do that before starting your tests of custom reordering.

alotbsol555 commented 3 months ago

thanks for looking into this! however, after deleting all my subscriptions to make some screenshots with a short list, the issue was gone… even after reimporting everything this works now.

my only guess is this: if you have only e.g. 3 subscriptions and rearrange them, there is a short flicker below the list, before the new correct order is visible. maybe the process got stuck there, and the list was shown twice (the list was always ok after switching to a different tab and coming back to subscriptions). is it possible that the update from the previous version (without the ability to rearrange) put the list items into some undefined state, which caused the issue!?

one last point: my subscriptions contained not only accounts but also search terms, if that makes a difference…

j-fbriere commented 2 months ago

After more tests I found that there was an issue indeed. Thank you. The version v3.8.2 fixes this issue.

j-fbriere / squawker