j-fbriere / squawker

An open-source privacy oriented Twitter/X client
MIT License
799 stars 16 forks source link

Hebrew Translation #284

Open maeotae opened 2 months ago

maeotae commented 2 months ago

Checklist

Affected version

3.8.0

Steps to reproduce the bug

  1. Go to 'a Hebrew written post'
  2. Press on 'the translation symbol'

Expected behavior

No response

Actual behavior

"language iw is not supported from host translate.fedilab.app"

Screenshots/Screen recordings

Screenshot_20240407_173029_Squawker

Logs

No response

Affected Android/Custom ROM version

Android 14/One UI 6.0

Affected device model

Samsung S22 Ultra

Additional information

No response

j-fbriere commented 2 months ago

The error says: "language iw is not supported from..."

I googled to know what is the language code iw. It's the old standard for the language code of Hebrew. The official current standard is the language code he (since 1989). So Twitter/X (or @kann_news) uses the old standard for the language code of Hebrew, but the translation site translate.fedilab.app do not recognize that old language code for Hebrew, hence the error. Squawker will simply replace iw by he before sending the text to be translated by the translation site.

j-fbriere commented 2 months ago

Version v3.8.1 should fix it.