Newly saved tweets added to the end of the list

zihu12 commented 2 weeks ago

Checklist

[X] I am able to reproduce the bug with the latest version.
[X] I made sure that there are no existing issues - open or closed - which I could contribute my information to.
[X] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
[X] This issue contains only one bug, that only occurs in Squawker

Affected version

v3.8.3+300016323

Steps to reproduce the bug

Open the Application and go to saves tab(must go to the tab to reproduce)
go somewhere in the app and save a tweet
return to the saved tab and see the list

Expected behavior

The tweet saved in step 2 added to the top of the lisr

Actual behavior

The tweet was added to the end

Screenshots/Screen recordings

screen recording.zip

Logs

No response

Affected Android/Custom ROM version

Android 13/MIUI 14.0.8.0

Affected device model

No response

Additional information

IIRC the issue appeared a few updates before the latest version through I forgot when first appeared :(

zihu12 commented 2 weeks ago

Title changed based on the new findings Sorry for the incorrect previous infomation since when having multiple saves it's easily treated as missing until you test with data reset :(

zihu12 commented 2 weeks ago

Git blame says that the code comes from https://github.com/j-fbriere/squawker/commit/0efd771412f8154c3a67d4ab59b3573dcda81ebc#diff-f8244de5f9b043137a13fb4ade832aa9519fee553e67fc4732d70cd3497be458 when it's still fritter? Seems that only occurs in Squawker is not the case :( That said, fritter have no commits for nearly a year, so do we still need to talk about that? Or this is intentional behavior?

Anyway the code in that PR is tested working on my device(I say do what its title says)

j-fbriere commented 2 weeks ago

Thank you!

j-fbriere / squawker