j-fu / VoronoiFVM.jl

Solution of nonlinear multiphysics partial differential equation systems using the Voronoi finite volume method
MIT License
202 stars 34 forks source link

Allocation hunt #46

Closed j-fu closed 1 year ago

j-fu commented 1 year ago

Remove allocations from all form factor calculations

codecov-commenter commented 1 year ago

Codecov Report

Base: 83.23% // Head: 82.43% // Decreases project coverage by -0.79% :warning:

Coverage data is based on head (a590f17) compared to base (b5c3e11). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #46 +/- ## ========================================== - Coverage 83.23% 82.43% -0.80% ========================================== Files 18 18 Lines 2237 2067 -170 ========================================== - Hits 1862 1704 -158 + Misses 375 363 -12 ``` | [Impacted Files](https://codecov.io/gh/j-fu/VoronoiFVM.jl/pull/46?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/vfvm\_formfactors.jl](https://codecov.io/gh/j-fu/VoronoiFVM.jl/pull/46/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3Zmdm1fZm9ybWZhY3RvcnMuamw=) | `94.84% <100.00%> (+0.03%)` | :arrow_up: | | [src/vfvm\_system.jl](https://codecov.io/gh/j-fu/VoronoiFVM.jl/pull/46/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3Zmdm1fc3lzdGVtLmps) | `81.40% <100.00%> (-1.47%)` | :arrow_down: | | [src/vfvm\_quantities.jl](https://codecov.io/gh/j-fu/VoronoiFVM.jl/pull/46/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3Zmdm1fcXVhbnRpdGllcy5qbA==) | `85.18% <0.00%> (-1.49%)` | :arrow_down: | | [src/vfvm\_xgrid.jl](https://codecov.io/gh/j-fu/VoronoiFVM.jl/pull/46/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3Zmdm1feGdyaWQuamw=) | `62.96% <0.00%> (-1.33%)` | :arrow_down: | | [src/vfvm\_solvercontrol.jl](https://codecov.io/gh/j-fu/VoronoiFVM.jl/pull/46/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3Zmdm1fc29sdmVyY29udHJvbC5qbA==) | `79.16% <0.00%> (-0.84%)` | :arrow_down: | | [src/vfvm\_solver.jl](https://codecov.io/gh/j-fu/VoronoiFVM.jl/pull/46/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3Zmdm1fc29sdmVyLmps) | `78.94% <0.00%> (-0.51%)` | :arrow_down: | | [src/vfvm\_geometryitems.jl](https://codecov.io/gh/j-fu/VoronoiFVM.jl/pull/46/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3Zmdm1fZ2VvbWV0cnlpdGVtcy5qbA==) | `81.67% <0.00%> (-0.47%)` | :arrow_down: | | [src/vfvm\_postprocess.jl](https://codecov.io/gh/j-fu/VoronoiFVM.jl/pull/46/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3Zmdm1fcG9zdHByb2Nlc3Muamw=) | `97.56% <0.00%> (-0.29%)` | :arrow_down: | | [src/vfvm\_impedance.jl](https://codecov.io/gh/j-fu/VoronoiFVM.jl/pull/46/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3Zmdm1faW1wZWRhbmNlLmps) | `97.03% <0.00%> (-0.28%)` | :arrow_down: | | ... and [5 more](https://codecov.io/gh/j-fu/VoronoiFVM.jl/pull/46/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.