search

j-fu / VoronoiFVM.jl

Solution of nonlinear multiphysics partial differential equation systems using the Voronoi finite volume method
MIT License
183 stars 33 forks source link

add optional time printing #56

Closed dilaraabdel closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Base: 83.15% // Head: 83.12% // Decreases project coverage by -0.03% :warning:

Coverage data is based on head (e783159) compared to base (556ef67). Patch coverage: 87.50% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #56 +/- ## ========================================== - Coverage 83.15% 83.12% -0.03% ========================================== Files 20 20 Lines 2273 2275 +2 ========================================== + Hits 1890 1891 +1 - Misses 383 384 +1 ``` | [Impacted Files](https://codecov.io/gh/j-fu/VoronoiFVM.jl/pull/56?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/vfvm\_solvercontrol.jl](https://codecov.io/gh/j-fu/VoronoiFVM.jl/pull/56?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3Zmdm1fc29sdmVyY29udHJvbC5qbA==) | `80.00% <ø> (ø)` | | | [src/vfvm\_solver.jl](https://codecov.io/gh/j-fu/VoronoiFVM.jl/pull/56?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3Zmdm1fc29sdmVyLmps) | `76.65% <87.50%> (-0.12%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

j-fu commented 1 year ago

Hi basically I would agree to have this. OTOH it might be more interesting to support progressbars. What do you think about this ?

j-fu commented 1 year ago

This is resolved by the new verbosity handlung in 0.19